Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Update WMT16 standard hparams #265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update WMT16 standard hparams #265

wants to merge 1 commit into from

Conversation

pramodkaushik
Copy link

"num_encoder_layers" and "num_decoder_layers" are set in nmt.create_hparams() (Line 595 in nmt.py), but not updated after calling nmt.misc_utils.maybe_parse_standard_hparams() (Line 497 in nmt.py).

Fixes the issue (#264) where loading the pretrained checkpoint was resulting in an error.

"num_encoder_layers" and "num_decoder_layers" are set in nmt.create_hparams() (Line 595 in nmt.py), but not updated after calling nmt.misc_utils.maybe_parse_standard_hparams() (Line 497 in nmt.py). 

Fixes the issue (#264) where loading the pretrained checkpoint was resulting in an error.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@pramodkaushik
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants