Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of title - semantic search & fixed typo #43

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dinkofranceschi
Copy link

@dinkofranceschi dinkofranceschi commented Aug 2, 2021

This is a great tutorial! I suggest changing title of beginner_colab to help with semantic search. I also fixed a typo I came across in intermediate_colab.

This reverts commit 46fa52c.
This is a great tutorial! Just fixing a typo I came across.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla
Copy link

google-cla bot commented Aug 2, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 2, 2021
@dinkofranceschi
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 2, 2021
@dinkofranceschi dinkofranceschi changed the title Fixed typo Change of title - semantic search & fixed typo Aug 2, 2021
@janpfeifer
Copy link
Contributor

janpfeifer commented Aug 3, 2021

Thanks for the contribution.

The PR include several metadata changes, that we would rather not take in. Would you mind pointing out the change ? I'll do the change in our internal system and assign it to you.

(edited because of a misclick while writing it)

@janpfeifer janpfeifer closed this Aug 3, 2021
@janpfeifer janpfeifer reopened this Aug 3, 2021
@dinkofranceschi
Copy link
Author

dinkofranceschi commented Aug 3, 2021

Yes!

  1. I suggest changing the title of beginner_colab in order to help with semantic search:
    Build, train and evaluate Random Forests and Gradient Boosted Trees with TensorFlow Decision Forests

  2. Typo I came across in intermediate_colab in section "Build the models:"
    "apropriate" and "netrwork"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants