build windows/amd64 and darwin/arm64 binaries on pull request #6247
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
reviewed
Jul 5, 2024
stephanos
reviewed
Jul 6, 2024
rodrigozhou
reviewed
Jul 8, 2024
rodrigozhou
approved these changes
Jul 9, 2024
stephanos
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
build windows/amd64 and darwin/arm64 binaries on pull request
Why?
To ensure we don't introduce bugs that make it impossible to build our binaries for other common architectures.
binsis the only part ofci-build-miscthat needs to be tested on different architectures, so we don't need to run the entirety ofci-build-misc3x, just the bins part.How did you test it?
Checked the command locally, and ran the new action steps on this PR
Potential risks
Documentation
Is hotfix candidate?