-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update-with-start #1585
base: main
Are you sure you want to change the base?
Update-with-start #1585
Conversation
This reverts commit 8261633.
We don't need that until we use the PollUpdate API
response = await this.workflowService.updateWorkflowExecution(request); | ||
} while ( | ||
response.stage < UpdateWorkflowExecutionLifecycleStage.UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_ACCEPTED | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug fix against basic Update. Previously, if waitStage=Completed
we were issuing UpdateWorkflow
requests after the update has reached Accepted
. But that is not what we should do: we should issue UpdateWorkflow
until Accepted
and then switch to PollWorkflowUpdate
. All other SDKs do this.
This PR adds an API for "update-with-start", using the MultiOperation gRPC API.
PR is in draft mode because the test suite is incomplete, but please feel free to review the API and implementation.
The following code demonstrates the API and is taken from the early-return sample:
Public API
startUpdateWithStart
with interfacesWorkflowStartUpdateWithStartInput
andWorkflowStartUpdateWithStartOutput
WithStartWorkflowOperation
WorkflowClient.executeUpdateWithStart
andWorkflowClient.startUpdateWithStart