Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC cancellation support #174

Merged
merged 1 commit into from
Oct 21, 2024
Merged

RPC cancellation support #174

merged 1 commit into from
Oct 21, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Oct 21, 2024

What was changed

  • Added ability to provide Cancellation to all RPC calls to cancel them
  • Move rpc_metadata and rpc_timeout (and low-level rpc_retry) into Client::RPCOptions along with this new cancellation field
    • 3, sometimes 4 kwargs for advanced RPC options that are rarely set became too much

Why?

Checklist

  1. Closes [Feature Request] Client RPC call cancellation #168

@cretz cretz requested a review from a team October 21, 2024 13:13
@cretz cretz merged commit 67741fc into temporalio:main Oct 21, 2024
6 checks passed
@cretz cretz deleted the rpc-cancel branch October 21, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Client RPC call cancellation
2 participants
@cretz @Quinn-With-Two-Ns