(promql-to-dd-go) add new flag to control sleep duration between runs #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSimmons
reviewed
Jan 22, 2024
| @@ -29,7 +30,7 @@ const ( | |||
|
|
|||
| func (w *Worker) Run() { | |||
| interrupt := interruptCh() | |||
| ticker := time.NewTicker(w.QueryInterval) | |||
| ticker := time.NewTicker(w.SleepDuration) | |||
There was a problem hiding this comment.
is this doing a 20s sleep between [1m] queries? I think what we want is a 60s sleep
There was a problem hiding this comment.
@TimSimmons Yeps, that makes sense. The default value was borrowed from Python for consistency. Do you think we should make a change there too?
There was a problem hiding this comment.
I suppose it might just be constantly overwriting the data, which is maybe ok?
Previous, the sleep duration between each data pull/push and the query window was using the same setting/flag. This PR introduces a new flag to control sleep duration separately and default to 20s.
taonic
force-pushed
the
taonic/control_sleep_duration_separately
branch
from
78fbef0
to
f172d77
Compare
TimSimmons
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Previous, the sleep duration between each data pull/push and the query window was using the same setting/flag.
This PR introduces a new flag to control sleep duration separately and default to 60s. This is also aligned with the Python implementation:
samples-server/cloud/observability/promql-to-dd.py
Line 62 in 78fbef0
Output (new default 60 seconds interval):
Checklist
Closes
How was this tested:
Manual (see above)
Any docs updates needed?