Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Ensure templateflow Layout is re-indexed when updating #59

Merged
merged 6 commits into from
Sep 14, 2020

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented Aug 17, 2020

Closes #58

Needs a unittest.

Also fixes the failing unittest, and catches a bug where allow_redirect was not being passed onto certain requests.

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@1c473df). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage          ?   87.85%           
=========================================
  Files             ?        5           
  Lines             ?      214           
  Branches          ?        0           
=========================================
  Hits              ?      188           
  Misses            ?       26           
  Partials          ?        0           
Flag Coverage Δ
#api 87.85% <100.00%> (?)
#config 55.14% <85.71%> (?)
#datalad 78.50% <100.00%> (?)
#dls3 55.60% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
templateflow/conf/__init__.py 88.88% <100.00%> (ø)
templateflow/conf/_s3.py 97.91% <100.00%> (ø)
templateflow/api.py 77.90% <0.00%> (ø)
templateflow/conf/bids.py 100.00% <0.00%> (ø)
templateflow/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c473df...72811b8. Read the comment docs.

@mgxd
Copy link
Contributor Author

mgxd commented Aug 31, 2020

@oesteban pinging here

templateflow/tests/test_api.py Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@mgxd mgxd merged commit 1de3c71 into templateflow:master Sep 14, 2020
@mgxd mgxd deleted the fix/layout-reindex branch September 14, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TemplateFlow should re-index the BIDS layout after update
2 participants