Don't cache set-cookie header #2276
Open
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caching of set-cookie can lead to sharing sensitive client information and increases security risks. Little enhancement: During copy response to the cache we iterate over header table that contains empty headers, to not do bitwise operation on empty headers `TFW_STR_EMPTY` moved to first place in the condition.
EvgeniiMekhanik
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching of set-cookie can lead to sharing sensitive client information and increases security risks.
Little enhancement:
During copy response to the cache we iterate over header table that contains empty headers, to not do bitwise operation on empty headers
TFW_STR_EMPTYmoved to first place in the condition.