Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for js commas #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bmteller
Copy link

No description provided.

@bmteller
Copy link
Author

bmteller commented Oct 25, 2021

There was 1 failing test but this is unrelated and was already failing on the 1.1.2 tag.

  1) test copying strings on decode (Jason.DecodeTest)
     test/decode_test.exs:88
     Assertion with == failed
     code:  assert :binary.referenced_byte_size(key) == 14
     left:  3
     right: 14
     stacktrace:
       test/decode_test.exs:102: (test)

I think this is an OTP version issue.

If you look at master there is:

commit bdbd96d6d644c19cac008d1c277a2e13b77b4da5
Author: Michał Muskała <[email protected]>
Date:   Mon May 4 15:14:21 2020 +0100

    Fix reference string decoding test

    Closes #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant