-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go-billy to latest main to fix a git resolver issue #8306
base: main
Are you sure you want to change the base?
Conversation
Before the update of that dependency, a git repository that contains a symlink, that points outside of the repository, will fail. This means even though the definition (pipeline, task, …) that we are trying to fetch exists, the resolution will fail. With this bump, this is now fixed. Signed-off-by: Vincent Demeester <[email protected]>
/hold Waiting to see if we can get a |
@vdemeester as per thread on the issue:
Based on the above, my current advice is to use the pseudo versions from |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vdemeester: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
Before the update of that dependency, a git repository that contains a
symlink, that points outside of the repository, will fail. This means
even though the definition (pipeline, task, …) that we are trying to
fetch exists, the resolution will fail.
With this bump, this is now fixed.
Signed-off-by: Vincent Demeester [email protected]
/kind bug
Closes #7561
It probably needs a non-regression test, but I am a bit unsure what
repository to use for this. @afrittoli what do you think ? We could
create our own, or create one dynamically during the tests, …
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes