Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-billy to latest main to fix a git resolver issue #8306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vdemeester
Copy link
Member

Changes

Before the update of that dependency, a git repository that contains a
symlink, that points outside of the repository, will fail. This means
even though the definition (pipeline, task, …) that we are trying to
fetch exists, the resolution will fail.

With this bump, this is now fixed.

Signed-off-by: Vincent Demeester [email protected]

/kind bug

Closes #7561

It probably needs a non-regression test, but I am a bit unsure what
repository to use for this. @afrittoli what do you think ? We could
create our own, or create one dynamically during the tests, …

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

The git resolver will be able to resolve a resource even if there is an invalid symlink is present in the repository fetched (for anonymous fetching).

Before the update of that dependency, a git repository that contains a
symlink, that points outside of the repository, will fail. This means
even though the definition (pipeline, task, …) that we are trying to
fetch exists, the resolution will fail.

With this bump, this is now fixed.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 30, 2024
@vdemeester
Copy link
Member Author

/hold

Waiting to see if we can get a go-billy release out before merging this 👼🏼 @pjbgf

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2024
@pjbgf
Copy link

pjbgf commented Sep 30, 2024

@vdemeester as per thread on the issue:

unfortunately I don't have permission to cut releases within go-git. I am hoping we will cut new releases for both go-billy and go-git before the end of the year but that will depend on other maintainer's availability.

Based on the above, my current advice is to use the pseudo versions from master, which at present are more reliable and stable than the last cut releases.

@vdemeester
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2024
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2024
@vdemeester
Copy link
Member Author

cc @chitrangpatel

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2024
@tekton-robot
Copy link
Collaborator

@vdemeester: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git resolver does not work with repositories with a symlink
4 participants