mailgun/mailgun-php ^3.0 #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes tehplague#78 Fixes tehplague#79
|
|
|
Ah true. Just looked into it and not really sure what the right replacement code should be though. Will mark this as a draft. Someone feel free to take over from here. |
|
Looks like you can just use the constructor instead of a factory method. Maybe I'll have a look. Do you know of a way I can continue working on your PR, or should I start a new one? |
|
The PR is pretty simple so probably easiest to just submit a new one. |
|
I submitted a new one: #85 |
|
Closing in favor of #85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
mailgun/mailgun-phppackage to^3.0, which fixes dependency conflicts with Symfony 4.2+ (#78, #79), as well as php-http/guzzle7-adapter.