Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Gym Info #149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added Gym Info #149

wants to merge 2 commits into from

Conversation

jadbalout
Copy link
Contributor

@jadbalout jadbalout commented Jul 31, 2016 •
edited
Loading

http://prnt.sc/bzv9lt
http://prntscr.com/bzvgbq
CSS expert needed to fix circled image please.

@BobbyWibowo
Copy link

BobbyWibowo commented Jul 31, 2016 •
edited
Loading

Honestly, I can't ever view picture in Lightshot. Mind uploading them somewhere else? 😕

@jadbalout
Copy link
Contributor Author

@BobbyWibowo nott sure if that will work but try:
https://slack-imgs.com/?c=1&url=http%3A%2F%2Fimage.prntscr.com%2Fimage%2F5db7aea66a8a4507927840ac4548dc5f.png
also mind testing it pls:?

@BobbyWibowo
Copy link

Honestly, that's nice. I think I'm gonna implement that to my fork (it's a personal build thingy). Thanks!
👍

@jadbalout
Copy link
Contributor Author

jadbalout commented Jul 31, 2016 •
edited
Loading

@BobbyWibowo once you do implement it, tell me if it works, I did a good amount of changes and I'm not sure whether I uploaded them all or not.

@BobbyWibowo
Copy link

I actually ended up writing it from scratch since my personal build was based on wchill/refactor branch and I already had a few customization beforehand, but well, here's how I implemented it: https://github.com/BobbyWibowo/OpenPoGoWeb/commit/4f9fe1937973900b7d29de1528f293f59c30361c#commitcomment-18464499. Feel free to salvage the styling if you want.

@jadbalout jadbalout mentioned this pull request Aug 1, 2016
Closed
@MaxLeiter
Copy link
Contributor

MaxLeiter commented Aug 1, 2016 •
edited
Loading

I think the circular image can wait for another PR, thanks!

👍

Approved with PullApprove

@BobbyWibowo BobbyWibowo mentioned this pull request Aug 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jadbalout @BobbyWibowo @MaxLeiter