Skip to content

Commit

Permalink
Fix: webapp is failing because of linting
Browse files Browse the repository at this point in the history
  • Loading branch information
harshithmullapudi committed Dec 20, 2024
1 parent 7d2283d commit 6786541
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export const CommentsActivity = observer(

return (
<div className="my-2 w-full flex flex-col gap-4">
{commentOrder == 1 && <IssueComment />}
{commentOrder === 1 && <IssueComment />}
<Timeline>
{sortedComments
.filter((comment: IssueCommentType) => !comment.parentId)
Expand Down
18 changes: 9 additions & 9 deletions apps/webapp/src/modules/projects/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
import { Button } from '@tegonhq/ui/components/button';
import { AddLine, DocumentLine, IssuesLine } from '@tegonhq/ui/icons';
import { observer } from 'mobx-react-lite';
import Link from 'next/link';
import React from 'react';

import { HeaderLayout } from 'common/header-layout';
Expand All @@ -14,21 +15,20 @@ import { useProject } from 'hooks/projects';

import { ProjectDetailsDropdown } from './dropdowns/project-details-dropdown';
import { NewProjectDialog } from './new-project-dialog';
import Link from 'next/link';

interface HeaderProps {
title: string;
isProjectView?: boolean;
view?: string;
setView?: (view: 'overview' | 'issues') => void;
href?:string
href?: string;
}

export const Header = observer(
({ title, isProjectView, view, setView, href }: HeaderProps) => {
const [newProjectDialog, setNewProjectDialog] = React.useState(false);
const project = useProject();

const actions = (
<>
{!isProjectView && (
Expand All @@ -51,13 +51,13 @@ export const Header = observer(
<HeaderLayout actions={actions}>
<Breadcrumb>
<BreadcrumbItem>
{href?
<Link href={href}>
<BreadcrumbLink>{title}</BreadcrumbLink>
</Link>
:
{href ? (
<Link href={href}>
<BreadcrumbLink>{title}</BreadcrumbLink>
}
</Link>
) : (
<BreadcrumbLink>{title}</BreadcrumbLink>
)}
</BreadcrumbItem>
{isProjectView && (
<>
Expand Down
10 changes: 8 additions & 2 deletions apps/webapp/src/modules/projects/project-view/project-view.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { observer } from 'mobx-react-lite';
import { useRouter } from 'next/router';
import React from 'react';

import { AppLayout } from 'common/layouts/app-layout';
Expand All @@ -14,7 +15,6 @@ import { Overview } from './overview';
import { RightSide } from './overview/right-side';
import { ProjectProgress } from './project-progress';
import { Header } from '../header';
import { useRouter } from 'next/router';

export const Project = observer(({ view }: { view: 'overview' | 'issues' }) => {
const project = useProject();
Expand Down Expand Up @@ -50,7 +50,13 @@ export const ProjectView = withApplicationStore(() => {
return (
<MainLayout
header={
<Header title="Projects" isProjectView view={view} setView={setView} href={`/${workspaceSlug}/projects`} />
<Header
title="Projects"
isProjectView
view={view}
setView={setView}
href={`/${workspaceSlug}/projects`}
/>
}
>
<ContentBox>
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/icons/arrow_down.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ export function ArrowDown({ size = 18, className, color }: IconProps) {
return (
<svg
width={size}
className={className}
height={size}
viewBox="0 0 16 16"
fill="none"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M8 1.99512C7.58578 1.99512 7.25 2.3309 7.25 2.74512V11.4393L4.63414 8.82347C4.34124 8.53058 3.86637 8.53058 3.57348 8.82347C3.28058 9.11636 3.28058 9.59124 3.57348 9.88413L7.46967 13.7803C7.76256 14.0732 8.23744 14.0732 8.53033 13.7803L12.4265 9.88413C12.7194 9.59124 12.7194 9.11636 12.4265 8.82347C12.1336 8.53058 11.6587 8.53058 11.3659 8.82347L8.75 11.4393V2.74512C8.75 2.3309 8.41421 1.99512 8 1.99512Z"
fill="black"
style="fill:black;fill-opacity:1;"
fill={color ? color : 'currentColor'}
/>
</svg>
);
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/icons/arrow_up.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ export function ArrowUp({ size = 18, className, color }: IconProps) {
<svg
width={size}
height={size}
className={className}
viewBox="0 0 16 16"
fill="none"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M8 14C8.41421 14 8.75 13.6642 8.75 13.25V4.55578L11.3659 7.17164C11.6587 7.46453 12.1336 7.46453 12.4265 7.17164C12.7194 6.87874 12.7194 6.40387 12.4265 6.11098L8.53033 2.21479C8.23744 1.92189 7.76256 1.92189 7.46967 2.21479L3.57348 6.11098C3.28058 6.40387 3.28058 6.87874 3.57348 7.17164C3.86637 7.46453 4.34124 7.46453 4.63414 7.17164L7.25 4.55578V13.25C7.25 13.6642 7.58578 14 8 14Z"
fill="black"
style="fill:black;fill-opacity:1;"
fill={color ? color : 'currentColor'}
/>
</svg>
);
Expand Down

0 comments on commit 6786541

Please sign in to comment.