stop creating tables for views and instead create view for them #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The thought of supporting views never crossed my mind. It will sure be good addition. Please make sure to add unit tests for this. |
|
@dethrophes any more progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm neither a python nor SQL person.
Having said that I find it a bit weird that currently the script is creating a real table for all the views and then populating the views with the data.
Which much be exploding the db size, if you use views in sqlite3?
So here I added a hacky approach to instead just create a view for the views.
Not saying this is finished, just providing for feedback.
It seems to work at least for me in my limited testing.
Cheers.