Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with latest source to prevent deprecation warnings #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kaliatech
Copy link

I understand this is a no longer supported package, however, this might be helpful to others still using this package. In #23 the source was updated to prevent deprecation warnings (thank you!), however, the dist packages were not updated

This PR builds the files in /dist with that latest source. In order to do so using newer tools, I had to update to a newer jake. So, I then went ahead updated all dependencies to latest. As part of that, I had to make a minor tweak to the UglifyJS config.

Changes:

  • Newer dependencies
  • Modified package version specifier to require leaflet-1.0.0 or newer. (Probably not required in hindsight).
  • Modified uglifyjs config to remove a no longer supported option.
  • Updates the version in package.json to 0.1.1 in case this ever gets pushed to NPM registry.

Note that running jake test results in an error, likely due to the significant jake version changes. I did not debug.

Copy link

@jprusik jprusik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw (and anyone else finding their way here), this worked for me (the dependencies updates did not seem necessary); smoked tested with no obvious (undesired) side-effects:

npm install leaflet.pattern@https://github.com/teastman/Leaflet.pattern/tarball/ac9f69f

@thbar
Copy link

thbar commented Aug 8, 2023

Thanks for sharing this ; we are facing a "double-bundling" of leaflet (etalab/transport-site#3376) and it looks like this PR could solve it!

Poke @teastman if you are still around and willing to merge / release package!

@thomaslrg
Copy link

Looking forward to the release, @teastman. This PR will be a great addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants