Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly handle nodes with names that are a prefix of other node names #35

Merged
merged 2 commits into from
Feb 8, 2024
Merged

properly handle nodes with names that are a prefix of other node names #35

merged 2 commits into from
Feb 8, 2024

Conversation

ottojo
Copy link
Member

@ottojo ottojo commented Feb 5, 2024

No description provided.

@ottojo ottojo requested a review from authaldo February 5, 2024 16:28
@ottojo ottojo mentioned this pull request Feb 5, 2024
Merged
authaldo
authaldo approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@authaldo authaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing up and fixing this edge case!

In my view having nodes named the same as the namespace of other nodes should be considered bad practice. Nonetheless, supporting this edge case is nice.

@authaldo authaldo merged commit b80672f into feat_node_tree Feb 8, 2024
1 check passed
@authaldo authaldo deleted the node_namespace_name_collision branch February 8, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@authaldo authaldo authaldo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ottojo @authaldo