Improvements for handling string parameters #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottojo
reviewed
Aug 6, 2023
Co-authored-by: Jonas Otto <[email protected]>
ottojo
approved these changes
Aug 7, 2023
# Conflicts: # src/rig_reconfigure.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of rig_reconfigure, every character modification within a string parameter causes an update which is sent to the respective node.
This MR modifies the behaviour:
An update is now only sent to the node if the editing is finished by pressing enter or the input field is deselected. For the future it might also be interesting to include a timeout which handles situations where the user has finished editing but forgets to press enter (and doesn't change the focus within the window).
The timeout is not part of this MR but might be added in the future. Given the low usage of string parameters within our internal software stack, the timeout is currently solely a low priority enhancement.
The MR further includes minor layout changes which ensure that nesting doesn't cause textfields to span across the border of the window (if the window is large enough to handle the top level text fields).