pokr.kr Dockerize #57
Draft
+93
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooddang
reviewed
Sep 12, 2019
| @@ -0,0 +1,27 @@ | |||
| FROM python:2 | |||
There was a problem hiding this comment.
기왕 하시는 김에 python 3.7 기준으로 해보는 것이 어떠세요?
|
front 나누는건 사실 스토리지를 공유하고 npm 컨테이너를 나눌까 생각해봤던건데 애매하긴 하겠네요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR입니다
Issue
#56
Description
빠르게 할 여건은 안되고 몇 번 핑퐁 칠 생각으로 Draft PR 만들어둡니다.
전체적인 구조는 backend와 npm을 필요로 하는 front docker를 분리하고 디비도 컨테이너를 분리해서
docker-compose로 배포되도록 하려고 합니다.
이렇게 4개의 컨테이너를 함께 띄우는 식이 될 것 같구요.
Dockerfile -> pokr-backend
Dockerfile_front -> pokr-frontend
우선 이렇게 구성할 예정인데 front가 떼어질 수 있는 구조인지는 아직 제대로 파악을 못했네요.
안되면 multi-stage build로 좀 구간을 나눠보는 것도 좋을 것 같습니다.