-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1806 Add DevContainer configuration #1807
base: main
Are you sure you want to change the base?
Conversation
This commit introduces DevContainers based on quickstart, improving the handling of the development environment. Ports 80 (quickstart project) and 8025 (mailhog) are forwarded within the DevContainer setup. This enhances connectivity and ease of access for local development and debugging with frontend services running inside the container.
Introduce a new "build:dev" script in the frontend package.json to allow parallel builds. Modify related development commands in frontend-sdk and elements to use the correct "build:dev" command. Adjust docker-compose setup to run the new "build:dev" script.
Simplify the Nginx setup by removing the elements-nginx service and directly serving static files from the main Nginx container. Updated volume mounts and configuration to reflect these changes.
…cture Moved dev containers related files to .devcontainer for better organization and simplified path references in devcontainers-full-setup.yaml.
Updates on Todos:
The
Updated the frontend
Copied the quickstart config to
|
The /mail/ proxy location block has been deleted from the devcontainer-nginx.conf file.
/award 1500 |
Awarding MarianPalkus: 1500 points 🕹️ Well done! Check out your new contribution on oss.gg/MarianPalkus |
Description
Add DevContainers based on quickstart-project to improve the handling of the development environment. Ports 80 (quickstart project) and 8025 (mailhog) are forwarded within the DevContainer setup.
Addressing #1806.
Implementation
Tests
The setup can be tried here:
The quickstart-example should be fully working:
Todos
entry
in the devcontainer docker-compose file might not be required.devcontainers
directoryAdditional context