Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aspects loading fixes #6308

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

aspects loading fixes #6308

wants to merge 23 commits into from

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Aug 14, 2022

Proposed Changes

  • do not add extension with empty data and config to the component extension list on load
  • add non core aspects with id rather than name when they only register data on load (and has no component's config)
  • do not add data to self on component load
  • improve legacy extension list find function
  • ignore version when upserting extension data

… data on load (and has no component's config)
…ure we have main prop in package.json of the pkg correctly)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant