Add disabled option to text field #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dNitza Nice one. JS change looks fine. Wondering if we should add some specific styling to make it obvious when a form is disabled is the only thing. |
|
Hey @makenosound. Yeah I recon that's a good idea. Shall update the PR with that change when I get a chance :) |
|
Yep, that’d be great. I’m not sure we have an existing sort of style to suit that, but something probably:
... would be enough |
Wanted to do `composes: greyMidColor normal sans from styles;`, but mcss is le confusing
makenosound
reviewed
Jun 21, 2018
| @@ -10,3 +10,8 @@ | |||
| .code { | |||
| composes: mono from styles; | |||
| } | |||
|
|
|||
| :disabled { | |||
There was a problem hiding this comment.
This isn’t quite the right way to do this, @dNitza. CSS Modules stuff should be local and I think that selector will end up global by default. I’m going to merge the emotion branch into master soon (today hopefully) so perhaps back this out and we can redo it with the emotion setup?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets a text field to be disabled if the
disabledproperty in the AST istrue. A bunch of file have changed here (looks like style only) but the main change is here:8bef9c0