Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ module.exports = {
'plugin:react/jsx-runtime',
'google',
],
'root': true,
'parserOptions': {
'ecmaFeatures': {
'jsx': true,
Expand All @@ -34,7 +35,7 @@ module.exports = {
'linebreak-style': ['error', process.platform === 'win32' ? 'windows' : 'unix'],
'max-len': [
'error',
{'code': 80, 'ignoreStrings': true},
{ 'code': 80, 'ignoreStrings': true },
],
'no-restricted-imports': [
'error',
Expand Down
8 changes: 1 addition & 7 deletions examples/api-list/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,7 @@
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject"
},
"eslintConfig": {
"extends": [
"react-app",
"react-app/jest"
]
},
},
"browserslist": {
"production": [
">0.2%",
Expand Down
64 changes: 32 additions & 32 deletions examples/api-list/src/App.js
Original file line number Diff line number Diff line change
@@ -1,36 +1,36 @@
import { useEffect } from "react";
import Container from "@mui/material/Container";
import CircularProgress from "@mui/material/CircularProgress";
import Grid from "@mui/material/Grid";
import Card from "@mui/material/Card";
import CardContent from "@mui/material/CardContent";
import CardMedia from "@mui/material/CardMedia";
import Typography from "@mui/material/Typography";
import { CardActionArea } from "@mui/material";
import Stack from "@mui/material/Stack";
import Button from "@mui/material/Button";
import {useEffect} from 'react';
import Container from '@mui/material/Container';
import CircularProgress from '@mui/material/CircularProgress';
import Grid from '@mui/material/Grid';
import Card from '@mui/material/Card';
import CardContent from '@mui/material/CardContent';
import CardMedia from '@mui/material/CardMedia';
import Typography from '@mui/material/Typography';
import {CardActionArea} from '@mui/material';
import Stack from '@mui/material/Stack';
import Button from '@mui/material/Button';

import "./App.css";
import './App.css';

import { useStore } from "./store";
import {useStore} from './store';

function App() {
const [images, setImages] = useStore.images();
const [loading, setLoading] = useStore.loading();
const [error, setError] = useStore.error();

useEffect(() => {
fetch("https://picsum.photos/v2/list")
.then((response) => response.json())
.then((images) => {
setImages(images);
})
.catch((error) => {
setError(error);
})
.finally(() => {
setLoading(false);
});
fetch('https://picsum.photos/v2/list')
.then((response) => response.json())
.then((images) => {
setImages(images);
})
.catch((error) => {
setError(error);
})
.finally(() => {
setLoading(false);
});
// eslint-disable-next-line
}, []);

Expand All @@ -41,7 +41,7 @@ function App() {
direction="column"
alignItems="center"
justifyContent="center"
style={{ minHeight: "100vh" }}
style={{minHeight: '100vh'}}
>
<CircularProgress />
</Grid>
Expand All @@ -50,19 +50,19 @@ function App() {
const ListView = (
<Grid
container
spacing={{ xs: 2, md: 3 }}
columns={{ xs: 4, sm: 8, md: 12 }}
spacing={{xs: 2, md: 3}}
columns={{xs: 4, sm: 8, md: 12}}
>
{images.slice(0, 12).map((data) => {
const { author, download_url, id } = data;
const {author, downloadUrl, id} = data;
return (
<Grid item xs={2} sm={4} md={4} key={id}>
<Card sx={{ maxHeight: 345 }}>
<Card sx={{maxHeight: 345}}>
<CardActionArea>
<CardMedia
component="img"
height="140"
image={download_url}
image={downloadUrl}
alt="green iguana"
/>
<CardContent>
Expand All @@ -84,8 +84,8 @@ function App() {
*/
const ViewToShow = loading ? LoadingView : error ? ErrorView : ListView;
return (
<Container maxWidth="lg" sx={{ mb: 4 }}>
<Stack spacing={2} direction="row" sx={{ py: 4 }}>
<Container maxWidth="lg" sx={{mb: 4}}>
<Stack spacing={2} direction="row" sx={{py: 4}}>
<Button variant="contained" onClick={() => setLoading(!loading)}>
Toggle Loading State
</Button>
Expand Down
17 changes: 9 additions & 8 deletions examples/api-list/src/index.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import React from "react";
import ReactDOM from "react-dom";
import "./index.css";
import App from "./App";
// eslint-disable-next-line no-restricted-imports
import React from 'react';
import ReactDOM from 'react-dom';
import './index.css';
import App from './App';
// import reportWebVitals from './reportWebVitals';

ReactDOM.render(
<React.StrictMode>
<App />
</React.StrictMode>,
document.getElementById("root")
<React.StrictMode>
<App />
</React.StrictMode>,
document.getElementById('root'),
);

// If you want to start measuring performance in your app, pass a function
Expand Down
4 changes: 2 additions & 2 deletions examples/api-list/src/reportWebVitals.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const reportWebVitals = onPerfEntry => {
const reportWebVitals = (onPerfEntry) => {
if (onPerfEntry && onPerfEntry instanceof Function) {
import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => {
import('web-vitals').then(({getCLS, getFID, getFCP, getLCP, getTTFB}) => {
getCLS(onPerfEntry);
getFID(onPerfEntry);
getFCP(onPerfEntry);
Expand Down
4 changes: 2 additions & 2 deletions examples/api-list/src/store.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import createStore from "teaful";
import createStore from 'teaful';

export const { useStore } = createStore({
export const {useStore} = createStore({
images: [],
loading: true,
error: false,
Expand Down
6 changes: 3 additions & 3 deletions examples/todo-list/src/AddTodoTask.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useState } from 'react';
import { useStore } from './store';
import {useState} from 'react';
import {useStore} from './store';

export default function AddTodoTask() {
const [counter, setCounter] = useState(0);
Expand All @@ -14,7 +14,7 @@ export default function AddTodoTask() {

setTodo({
...todo,
[counter]: { text: e.target.children[0].value, id: counter },
[counter]: {text: e.target.children[0].value, id: counter},
});
e.target.children[0].value = '';
setCounter(counter + 1);
Expand Down
10 changes: 5 additions & 5 deletions examples/todo-list/src/TodoList.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useStore } from './store';
import {useStore} from './store';

import Task from './Task';

Expand All @@ -9,21 +9,21 @@ export default function TodoList() {

const resolve = (task) => {
deleteTask(task.id);
setDone({ ...done, [task.id]: { ...task } });
setDone({...done, [task.id]: {...task}});
};

const unresolve = (task) => {
deleteTask(task.id, true);
setTodo({ ...todo, [task.id]: { ...task } });
setTodo({...todo, [task.id]: {...task}});
};

const deleteTask = (id, resolved) => {
if (resolved) {
const newDoneList = { ...done };
const newDoneList = {...done};
delete newDoneList[id];
setDone(newDoneList);
} else {
const newTodoList = { ...todo };
const newTodoList = {...todo};
delete newTodoList[id];
setTodo(newTodoList);
}
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@
"types": "dist/index.d.ts",
"scripts": {
"lint": "eslint ./package ./tests",
danielart marked this conversation as resolved.
Show resolved Hide resolved
"format": "eslint --fix ./package ./tests ./examples",
"format": "eslint --fix ./package ./tests",
"format:examples": "eslint --fix ./examples",
"test": "jest ./package ./tests",
"test:example:todo-list": "jest ./examples/todo-list",
"test:examples": "jest ./examples",
Expand Down