feat: skip interior rendering for glass-like blocks

Fix XeKr#1
teaconmc · Aug 6, 2022 · 7f1c6ff · 7f1c6ff
1 parent 4b582c8
commit 7f1c6ff
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 0 deletions.
diff --git a/src/main/java/org/teacon/xkdeco/block/IsotropicCubeBlock.java b/src/main/java/org/teacon/xkdeco/block/IsotropicCubeBlock.java
@@ -2,9 +2,11 @@
 
 import net.minecraft.MethodsReturnNonnullByDefault;
 import net.minecraft.core.BlockPos;
+import net.minecraft.core.Direction;
 import net.minecraft.world.level.BlockGetter;
 import net.minecraft.world.level.block.Block;
 import net.minecraft.world.level.block.state.BlockState;
+import org.jetbrains.annotations.NotNull;
 
 import javax.annotation.ParametersAreNonnullByDefault;
 
@@ -18,6 +20,11 @@ public IsotropicCubeBlock(Properties properties, boolean isGlass) {
         this.isGlass = isGlass;
     }
 
+    @Override
+    public boolean skipRendering(@NotNull BlockState pState, @NotNull BlockState pAdjacentBlockState, @NotNull Direction pDirection) {
+        return (this.isGlass && pAdjacentBlockState.is(this)) || super.skipRendering(pState, pAdjacentBlockState, pDirection);
+    }
+
     @Override
     @SuppressWarnings("deprecation")
     public float getShadeBrightness(BlockState state, BlockGetter world, BlockPos pos) {

diff --git a/src/main/java/org/teacon/xkdeco/block/IsotropicPillarBlock.java b/src/main/java/org/teacon/xkdeco/block/IsotropicPillarBlock.java
@@ -2,9 +2,11 @@
 
 import net.minecraft.MethodsReturnNonnullByDefault;
 import net.minecraft.core.BlockPos;
+import net.minecraft.core.Direction;
 import net.minecraft.world.level.BlockGetter;
 import net.minecraft.world.level.block.RotatedPillarBlock;
 import net.minecraft.world.level.block.state.BlockState;
+import org.jetbrains.annotations.NotNull;
 
 import javax.annotation.ParametersAreNonnullByDefault;
 
@@ -18,6 +20,11 @@ public IsotropicPillarBlock(Properties properties, boolean isGlass) {
         this.isGlass = isGlass;
     }
 
+    @Override
+    public boolean skipRendering(@NotNull BlockState pState, @NotNull BlockState pAdjacentBlockState, @NotNull Direction pDirection) {
+        return (this.isGlass && pAdjacentBlockState.is(this)) || super.skipRendering(pState, pAdjacentBlockState, pDirection);
+    }
+
     @SuppressWarnings("deprecation")
     public float getShadeBrightness(BlockState state, BlockGetter world, BlockPos pos) {
         return this.isGlass ? 1.0F : super.getShadeBrightness(state, world, pos);

diff --git a/src/main/java/org/teacon/xkdeco/block/IsotropicSlabBlock.java b/src/main/java/org/teacon/xkdeco/block/IsotropicSlabBlock.java
@@ -2,9 +2,11 @@
 
 import net.minecraft.MethodsReturnNonnullByDefault;
 import net.minecraft.core.BlockPos;
+import net.minecraft.core.Direction;
 import net.minecraft.world.level.BlockGetter;
 import net.minecraft.world.level.block.SlabBlock;
 import net.minecraft.world.level.block.state.BlockState;
+import org.jetbrains.annotations.NotNull;
 
 import javax.annotation.ParametersAreNonnullByDefault;
 
@@ -18,6 +20,11 @@ public IsotropicSlabBlock(Properties properties, boolean isGlass) {
         this.isGlass = isGlass;
     }
 
+    @Override
+    public boolean skipRendering(@NotNull BlockState pState, @NotNull BlockState pAdjacentBlockState, @NotNull Direction pDirection) {
+        return (this.isGlass && pAdjacentBlockState.is(this)) || super.skipRendering(pState, pAdjacentBlockState, pDirection);
+    }
+
     @Override
     @SuppressWarnings("deprecation")
     public float getShadeBrightness(BlockState state, BlockGetter world, BlockPos pos) {

diff --git a/src/main/java/org/teacon/xkdeco/block/IsotropicStairBlock.java b/src/main/java/org/teacon/xkdeco/block/IsotropicStairBlock.java
@@ -2,10 +2,12 @@
 
 import net.minecraft.MethodsReturnNonnullByDefault;
 import net.minecraft.core.BlockPos;
+import net.minecraft.core.Direction;
 import net.minecraft.world.level.BlockGetter;
 import net.minecraft.world.level.block.Blocks;
 import net.minecraft.world.level.block.StairBlock;
 import net.minecraft.world.level.block.state.BlockState;
+import org.jetbrains.annotations.NotNull;
 
 import javax.annotation.ParametersAreNonnullByDefault;
 
@@ -19,6 +21,11 @@ public IsotropicStairBlock(Properties properties, boolean isGlass) {
         this.isGlass = isGlass;
     }
 
+    @Override
+    public boolean skipRendering(@NotNull BlockState pState, @NotNull BlockState pAdjacentBlockState, @NotNull Direction pDirection) {
+        return (this.isGlass && pAdjacentBlockState.is(this)) || super.skipRendering(pState, pAdjacentBlockState, pDirection);
+    }
+
     @Override
     @SuppressWarnings("deprecation")
     public float getShadeBrightness(BlockState state, BlockGetter world, BlockPos pos) {