Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: ensure the IPR check runs on the PR head, not main #3480

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Nov 15, 2024

Local testing suggests that this will ensure that the IPR check actually fails on a PR when the PR author is new and unregistered.

@ljharb ljharb added the meta label Nov 15, 2024
@ljharb ljharb requested a review from a team November 15, 2024 18:13
scripts/check-form.js Outdated Show resolved Hide resolved
options: { all: { type: 'boolean', default: false } },
allowPositionals: true,
allowNegative: true,
strict: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(strict: true is the default.)

Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though in my ideal world we'd only check the new commits not all of them. Anything already in the repo can be assumed to be valid.

scripts/check-form.js Outdated Show resolved Hide resolved
@ljharb ljharb requested a review from a team November 21, 2024 17:27
@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Nov 21, 2024
@ljharb ljharb merged commit 0b6c5f1 into tc39:main Nov 21, 2024
8 checks passed
@ljharb ljharb deleted the fix-ipr branch November 21, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants