-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: ensure the IPR check runs on the PR head, not main #3480
Conversation
options: { all: { type: 'boolean', default: false } }, | ||
allowPositionals: true, | ||
allowNegative: true, | ||
strict: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(strict: true
is the default.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though in my ideal world we'd only check the new commits not all of them. Anything already in the repo can be assumed to be valid.
Local testing suggests that this will ensure that the IPR check actually fails on a PR when the PR author is new and unregistered.