Editorial: use proper comparison operation in LabelledEvaluation of LabelledStatement #3162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing
~empty~
guard in LabelledEvaluation for LabelledStatement.Currently, LabelledEvaluation for LabelledStatement is defined as follows:
According to the definition,
SameValue
, used in step 4, requires two arguments which are bothECMAScript langauge value
. In step 3,stmtResult.[[Target]]
can be~empty~
if there is noLabelIdentifier
in BreakStatement. Consequently, providingstmtResult.[[Target]]
as the argument forSameValue
should not be allowed.Following ECMAScript snippet can occur this case:
So fix this by adding more condition in step 4 for guard.