feat: Support bundle.ios.frameworks #9992
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stijnfrishert
force-pushed
the
9962-ios-frameworks
branch
from
91b69ea
to
2d1f0ee
Compare
stijnfrishert
force-pushed
the
9962-ios-frameworks
branch
from
18b9a13
to
3418cb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
bundle.ios.frameworksfor mobile iOS apps. This should close #9962.Work
From what I gathered, these were the necessary steps:
frameworksfield toIosConfig, just like it exists forMacConfig.IosConfigto theMetaDatapassed intocargo_mobile2that generates the Xcode project.Moreover, I found a bug in the
project.ymlhandlebars file, where the frameworks weren't unrolled correctly.Checks
I've inspected the resulting
project.ymland Xcode project and the framework is listed in the Link Binary with Libraries step.I get a build error in the Xcode build phase running
cargo tauri ios xcode-script, but I'm not sure how to figure out what's wrong. If any of the iOS devs could help me out, that would be sublime. :)Questions
IosConfig::frameworksfield is entirely correct. I copy/pasted it fromMacConfigand replaced MacOS with iOS. Can we use full paths here as well, like it states?IosConfig, but do we want to check for an environment variable first (just like the development team id)? What should its name be?