Correct your spacing #359
Open
Correct your spacing #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will normalize spacing in C to use spaces only and remove trailing whitespace.
This removes trailing whitespace and uses spaces consistently instead of tabs. This commit is generated by coala.
|
(Apparently you don't use travis? Maybe you should remove the config then...) |
|
Hi, apologies that it took us so long to get back to you - it's been a busy time. We ran uncrustify on the development branch a while back, which also fixed some spacing problems I think. This hasn't been merged back into master yet. I hope you understand I'd prefer not to accept this PR right now, to prevent merge conflicts later on. As for the coala configuration, our quality guys need to look into whether or not we'll start using coala. @ISY-Thomas @maartenvds @asselj ? |
|
sure, ping me when you need something. You can just remove the commits that change your code, rebase on whatever you want and run coala again to get it redone without conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm currently trying to distract myself from some very important but boring university work so I took 5 minutest to correct your spacing (which was rather inconsistent apparently, but you seem to prefer spaces over tabs in general) with coala since you showed interest in the project. If you want some cool analysis I can recommend you the MarkdownBear which will reformat your markdown uniformly and ClangBear which uses Clang to do fancy analytics on your C code :)