Fixes needed for Raspberry PI build on latest Raspbian #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 7fcd7f7 changed this method. Signed-off-by: Eric Nelson <[email protected]>
Without this, we get an undefined symbol at link time. Signed-off-by: Eric Nelson <[email protected]>
The Url::resolve() calls in main.cpp appear to be backwards and should add the current working directory to the base (file://) instead of the reverse. Signed-off-by: Eric Nelson <[email protected]>
Without this, I saw lockups that prevented additional characters from being read in the getKey() routine. Signed-off-by: Eric Nelson <[email protected]>
matteblair
requested changes
Aug 7, 2021
There was a problem hiding this comment.
Thanks for the URL fixes!
The getKey() changes didn't seem to make any difference on my Pi. My keyboard inputs are being ignored both with and without this change. But if this change helps for you then let's keep it!
I'd ask that you change the library configuration that I commented on, then this will be good to merge.
| @@ -40,6 +40,7 @@ target_link_libraries(tangram | |||
| /opt/vc/lib/libbrcmGLESv2.so | |||
| /opt/vc/lib/libvchiq_arm.so | |||
| /opt/vc/lib/libvcos.so | |||
| /usr/lib/arm-linux-gnueabihf/libatomic.so.1 | |||
There was a problem hiding this comment.
Using just atomic here seems to work on my pi. If it works on yours too, can you replace the path here with atomic? I'd rather not hard-code libraries where it isn't necessary.
|
@matteblair Is it possible to use Tangram-es as an Navigation System with Route Directions on an Raspberry Pi 4? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates are needed in order to build on the latest version of Raspberry PI O/S.