Add disabled prop to List
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
changed the title
disabled prop to List
|
@tajo it looks like Netlify is trying to use a deprecated image, and should be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
This adds a top-level
disabledprop to theListcomponent to allow disabling all moves.I also added
isDisabledto therenderItemsprop, but it's technically not needed and I'm happy to take it back out if you prefer. I just thought it would be nice to avoid users needing to check bothvalue.disabledand whatever they're using to disable the overall list. I don't feel strongly though.This is a PR on top of a PR. I recommend merging #105 first, otherwise it will get closed along with this PR.