Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies and Java (#41) #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dvbeek
Copy link

@dvbeek dvbeek commented Nov 11, 2022

Updated the dependencies to the latest versions and Java version to Java 17.
Tested it locally (with gpsd-nmea-simulator docker) with the project Tester, and in our own project.
Peer reviewed by my colleague 'mydeveloperplanet'.

Signed-off-by: Dennis van Beek [email protected]

@0x08
Copy link

0x08 commented Nov 11, 2022

Does this mean that future versions of the library will have a Java17 dependency? If so this might not be ideal: not everyone is there yet and it might be necessary to maintain multiple versions for this then.

@dvbeek
Copy link
Author

dvbeek commented Nov 11, 2022

@0x08 This indeed is a major change, I would recommend increasing the major version to show this.

I don't think 2 versions have to be maintained, because I don't expect a lot of functionality to be added in the coming months (the last release was more than 5 years ago).
But of course we can also lower the Java version to something like Java 11, to increase applicability?

@0x08
Copy link

0x08 commented Nov 11, 2022

Maybe Java11 would be a good compromise for now? A version that is widespread and still quite recent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants