🪄 [QA] Update stage environments #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
When user was typing the balance amount manually then input was not updating values correctly. We moved to `useCallback` instead of `useEffect` and fixed the condition for updating parent component with new values.
We had a mistake with the expected behavior.
…870) We had a mistake with the expected behavior.
✅ Deploy Preview for taho-development ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Resolves #866 ## What has been done Messages from assistant were not displayed correctly due to unnecessary `useEffect`. Also extracted some `Island` logic to `useOnRealmClick` hook. ## Testing - [x] Clear `localStorage` - [x] Connect wallet that is not staked in any realm - [x] After entering portal, `Welcome to Subscape, Nomad` message appears - [x] After clicking on realm for first time, `Why join a realm` message appears
### What Prepare app for the end of beta season, changes when `IS_BETA_CLOSED = true` are: - countdown shows time left to claim XP  - there are no challanges visible  - staking is impossible  - There is a hint below the claimable XP  - there are no "stake to join realm" or "you are already staked in another realm" banners visible (as it is no longer possible to stake) ### Testing - [x] with `IS_BETA_CLOSED = true` test changes listed above - [x] with `IS_BETA_CLOSED = false` - there should be no changes compared to prod env
Resolves #764 ### What When user was typing the balance amount manually then input was not updating values correctly. We moved to `useCallback` instead of `useEffect` and fixed the condition for updating parent component with new values. The issue was caused mostly by incorrect condition but I wanted to get rid of `useEffect` as the dependencies array was intentionally incomplete and it seems like it wasn't the most correct hook anyway. ### Testing General regression testing is needed here (@michalinacienciala). Let's not merge unless it will be tested for regressions. - [x] make sure scenarios written in the task above are working correctly now - [x] test staking and unstaking both full and partial amounts - [x] make sure we can stake/unstake values with decent precision (either by typing or using "max" button) 
## Pull request template This PR creates a pull request template that will be used for all pull requests, to make them consistent and always provide enough information about what was changes / what was added **The PR template looks like this:** ## Issues connected Resolves ## What has been done - Change 1 ## Testing - [ ] Test 1 ## Screenshots / images / videos Please provide assets necessary for the PR (remove if not applicable) **Open to suggestions, what should be changed / what should be added**
Ref #875 Ref #876 ## What has been done - Added "Beta has ended" modal on top of the map - Added "Portal is closed" modal on the onboarding page - Set flags to prevent users from entering the map, when portal is closed - Automatically clear onboarded wallet when portal is closed ## What is missing - Link to claim Galxe NFT - Endpoint for "Sign up" form ## Testing - [x] Set `IS_BETA_CLOSED` flag to `true` - [x] "Beta has ended" modal is on top of the map - [x] Modal can be closed - [x] Set `IS_PORTAL_CLOSED` flag to `true` - [x] Onboarded wallet is cleared from `localStorage` - [x] "Portal is closed" modal is on the onboarding page - [x] Population count is not visible - [x] Is it not possible to connect the wallet  
## Issues connected Ref #875 Ref #876 Resolves #878 ## What has been done - Added logic for sign up form - Added message for sign up form (success, failed, invalid email) ## Testing - [x] Entering no email - "Invalid email" message is displayed - [x] Entering not valid email - "Invalid email" message is displayed - [x] Entering valid email - "Sign up successful" message is displayed - [x] If sign up successful, email input is cleared - [x] All messages (success or fail) disappears after 3 seconds - [x] After sign up, email used will be visible in customer.io -> People ## Screenshots / images / videos 
## Issues connected Resolves #863 ## What has been done Modified text rendered when connecting dapp to Taho wallet ## Testing - [x] Connect your wallet, the text should be "Granting access to your account." ## Screenshots / images / videos 
## What has been done Week counter went above season duration, changed to be 7/7 ## Testing - [x] Set `BETA_IS_CLOSED` flag to `true` - current week is 7/7 ## Screenshots / images / videos 
## Issues connected Resolves #823 ## What has been done - Fixed ENS and UNS names not updated automatically (without reload) - Added `useCachedWalletName` hook ## Testing - [x] Clear `localStorage` - [x] Connect wallet - [x] After a short interval, account name is automatically updated - [x] Reload the page, the name is still visible
michalinacienciala
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request that upon merging will update stage environments with recent
mainchanges.The environments that will be updated:
Read more: Deployment to Production Flow