🚀 [QA] Update release environment #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had issues with triggering the `test-list.yml` workflow. It turned out this was because GitHub prevents from triggering workflows by events triggered by the `GITHUB_TOKEN` (and this was our case). To work around that we need to change the token used for creating the release PRs to a different one that `GITHUB_TOKEN` (we've decided to use a personal access token of the `thesis-valkyrie` user). We also needed to set `persist-credentials` parameter to `false` in `actions/checkout@v3` action in order to not save the auth token to the git config (thanks to this we'll be able to create PR with the specified PAT and trigger `test-list.yml` automatically after that event).
These are still pretty bare, and links to docs on how to do some of these things might be nice.
Names of the secrets cannot contain dashes. Changed `THESIS-VALKYRIE_PAT` to `THESIS_VALKYRIE_PAT`.
Handle adding Realm contracts by address. Connect to Base contract. Update storage version to trigger localstorage update.
⚠️ Merging this PR will add the realm - please approve but not merge before we are ready to publish the realm ### What Refactor to prepare for new realm - allow adding realm contracts by address - update existing realms to add them by address not name - removed the env flag to make it easier in the code to control the data - we need to update the storage version when the Base realm should become visible, it will be easier to just merge the PR to publish than to guard multiple places with feature flags Adding new realm - added Base realm by contract address - updated Leaderboard placeholder to match expected XP drop date - updated storage version to allow users to reload the realms data they have cached in local storage ### Testing - [x] clear the localstorage - [x] open the dapp on this branch and test new realm - [x] reload and see if everything is working fine - [x] clear the localstorage again - [x] go to `main` branch, load the dapp from `main` - [x] checkout this branch and reload the website - [x] make sure Base realm was added correctly 
Just added some minor notes with suggestions for combining tests to speed up the checklist process. I don't think any of what's there should be removed though.
We had issues with triggering the `test-list.yml` workflow. It turned out this was because GitHub prevents from triggering workflows by events triggered by the `GITHUB_TOKEN` (and this was our case). To work around that we need to change the token used for creating the release PRs to a different one that `GITHUB_TOKEN` (we've decided to use a personal access token of the `thesis-valkyrie` user). We also needed to set `persist-credentials` parameter to `false` in `actions/checkout@v3` action in order to not save the auth token to the git config (thanks to this we'll be able to create PR with the specified PAT and trigger `test-list.yml` automatically after that event). TODO: - [x] Configure personal access token for the `thesis-valkyrie` GH account and set it's value under the `THESIS_VALKYRIE_PAT` secret accessible by the `dapp` repository. The PAT should have `repo` scope. (@Shadowfiend) Useful links: * [Triggering a workflow from a workflow](https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow) * [Creating fine grained PATs](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#creating-a-fine-grained-personal-access-token) * [Switching off credentials persistency](https://github.com/orgs/community/discussions/26220#discussioncomment-3250853)
Resolves #678 Made all numbers values have two decimal points (except for integers like population)
Just added some minor notes with suggestions for combining tests to speed up the checklist process. I don't think any of what's there should be removed though.
Resolves #712 ## **What has been done** - Added "New" label to quest list (if the quest is new) - Added gif for a new quest on map - Modified the `Modal` component to support x-axis overflow  ## **Testing** - [ ] Clear the `localStorage` - [ ] Check if you "new quest" labels all over the map - [ ] Click on every realm and expand every accordion with "new quest" label - [ ] "New quest" label in the modal should disappear after expanding the accordion - [ ] When there are no more "New quest" labels in the modal, the label on the map that was over the realm should also disappear - [ ] For a new realm "New quest" labels are not displayed
**⚠️ This PR is base for Base Realm - all future commits and PRs connected with adding this realm should be branched out of this one** Resolves #711 ## **What has been done** - Added new realm to the map - Added "New realm" label to recent realm - Added blinking animation to recent realm - After clicking on realm, blinking animation and "New realm" label disappears (data for all clicked realm is stored in `localStorage` - Connected to contracts 
This is a pull request that upon merging will update stage environments with recent `main` changes. The environments that will be updated: * Stage live: https://stage-live--taho-development.netlify.app/ * Stage fork: https://stage-fork--taho-development.netlify.app/ Read more: [Deployment to Production Flow](https://github.com/tahowallet/dapp/blob/main/docs/testing-env.md)
✅ Deploy Preview for taho-development ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Release checklistThis release checklist should be performed before release is published.
Approve the PR when the checklist is finished ✅ Merge the PR when it is approved and we want to update the production Manual tests
|
- galxe questline text fixed - number of realms fixed
This is a pull request that upon merging will update stage environments with recent `main` changes. The environments that will be updated: * Stage live: https://stage-live--taho-development.netlify.app/ * Stage fork: https://stage-fork--taho-development.netlify.app/ Read more: [Deployment to Production Flow](https://github.com/tahowallet/dapp/blob/main/docs/testing-env.md)
michalinacienciala
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request that upon merging will update production environment with recent
stage-livechanges.The environment that will be updated:
Read more: Deployment to Production Flow