🚀 [QA] Update release environment #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Closes #576 This PR adds a logic for an extra check of assistant visibility.
Despite having configured the workflow to trigger when a PR with base branch `release` and head branch `stage-live` is opened, we didn't see the workflow to trigger in those circumstances. We've tested similar config in other repository and it was working there. The difference was that in the other repository the PR opened wasn't showing warning about the branch being out-of-date (and in case of the release PRs in `dapp` we see that warning). So it looks that this may affect workflow triggering. In this PR we want to verify if changing the triggering event to (`pull_request_target`)[https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target] will help. This event runs in the context of the base of the pull request, not in the context of the merge commit.
This is a pull request that upon merging will update stage environments with recent `main` changes. The environments that will be updated: * Stage live: https://stage-live--taho-development.netlify.app/ * Stage fork: https://stage-fork--taho-development.netlify.app/ Read more: [Deployment to Production Flow](https://github.com/tahowallet/dapp/blob/main/docs/testing-env.md)
✅ Deploy Preview for taho-development ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…616) Despite having configured the workflow to trigger when a PR with base branch `release` and head branch `stage-live` is opened, we didn't see the workflow to trigger in those circumstances. We've tested similar config in other repository and it was working there. The difference was that in the other repository the PR opened wasn't showing warning about the branch being out-of-date (and in case of the release PRs in `dapp` we see that warning). So it looks that this may affect workflow triggering. In this PR we want to verify if changing the triggering event to [`pull_request_target`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target) will help. This event runs in the context of the base of the pull request, not in the context of the merge commit.
This is a pull request that upon merging will update stage environments with recent `main` changes. The environments that will be updated: * Stage live: https://stage-live--taho-development.netlify.app/ * Stage fork: https://stage-fork--taho-development.netlify.app/ Read more: [Deployment to Production Flow](https://github.com/tahowallet/dapp/blob/main/docs/testing-env.md)
Release checklistThis release checklist should be performed before release is published.
Approve the PR when the checklist is finished ✅ Merge the PR when it is approved and we want to update the production Manual tests
|
This is a pull request that upon merging will update stage environments with recent `main` changes. The environments that will be updated: * Stage live: https://stage-live--taho-development.netlify.app/ * Stage fork: https://stage-fork--taho-development.netlify.app/ Read more: [Deployment to Production Flow](https://github.com/tahowallet/dapp/blob/main/docs/testing-env.md)
Update to Nov 8 (+7 days from last date)
This is a pull request that upon merging will update stage environments with recent `main` changes. The environments that will be updated: * Stage live: https://stage-live--taho-development.netlify.app/ * Stage fork: https://stage-fork--taho-development.netlify.app/ Read more: [Deployment to Production Flow](https://github.com/tahowallet/dapp/blob/main/docs/testing-env.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request that upon merging will update production environment with recent
stage-livechanges.The environment that will be updated:
Read more: Deployment to Production Flow