Skip to content

Commit

Permalink
Add workflow commenting release PRs with the tests list (#479)
Browse files Browse the repository at this point in the history
The commit introduces a GH ACtions workflow which adds a comment with
tests list to the PRs with the release candidates (PRs that want to
merge `stage-live` branch to the `release` branch). The test list should
be specified in the `./.github/workflows/test-list/release-test-list.md`
file. The comment will be added only once, right after the PR gets
created.

@andreachapman, @jagodarybacka - I didn't have time to focus on the
content of the test list, I only did some small changes there
(formatting + adding introduction). I think even if there are some tests
missing, we can merge as it is (if other things look ok) and Andrea (or
anybody else) can later update the test list separately.
  • Loading branch information
jagodarybacka authored Oct 23, 2023
2 parents f0c4d3a + 3212b41 commit f45d2f3
Show file tree
Hide file tree
Showing 2 changed files with 100 additions and 0 deletions.
25 changes: 25 additions & 0 deletions .github/workflows/test-list.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# This workflow adds a comment with tests list to the PRs with the release
# candidates (PRs that want to merge `release-*` branches to `main`). The test
# list is specified in the `./.github/workflows/test-list/release-test-list.md`
# file. The comment is added only once, right after the PR gets created.

name: Add test list to release PRs

on:
pull_request:
types:
- opened
branches:
- release

jobs:
add-release-test-list:
runs-on: ubuntu-latest
if: github.head_ref == 'refs/heads/stage-live'
permissions:
pull-requests: write
steps:
- uses: actions/checkout@v3
- uses: mshick/add-pr-comment@v2
with:
message-path: ./.github/workflows/test-list/release-test-list.md
75 changes: 75 additions & 0 deletions .github/workflows/test-list/release-test-list.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
# Release checklist

This release checklist should be performed before release is published.

- if something is not working please create an issue and link it here. Checkbox
should be checked only if everything was fine
- in case of serious issues or doubts you should ask the team first

**Approve the PR when the checklist is finished ✅**

**Merge the PR when it is approved and we want to update the production
environment 🚀**

## Manual tests

1. Connect to wallet with $TAHO
- [ ] you see the Portal is Open message
- [ ] you can see the map after entering
- [ ] you see your address connected

2. Connect to wallet that previously staked
- [ ] you see your address connected
- [ ] you see the name of your realm
- [ ] you can navigate to other realms but not stake in them
- [ ] you can stake more TAHO in that realm if you're not fully staked
- [ ] you can unstake

3. Connect to wallet that hasn't staked but has $TAHO
- [ ] you see your address connected
- [ ] you don't see a realm name beside that
- [ ] you can explore realms and stake into one

4. Connect to wallet that has NO $TAHO (& no $VETAHO)
- [ ] you see the portal is closed message and the wait list button
- [ ] wait list redirect works as expected
- [ ] you can't see the map

5. Switch connected wallet in the extension
- [ ] dapp reloads and shows the portal screen
- [ ] reloads with Connect Wallet button if you go to a wallet that's not
connected
- [ ] reloads with that address connected if that's a connected website for
the address: if it's an eligible address, you see Access Granted &
Enter the portal
- [ ] reloads with that address connected if that's a connected website for
the address: if it's an inelligible address, you see the portal is
closed message and wait list button

6. Helper Tool (note: this might be hard to test since with new releases, the
cache will always be fresh and these results may not be true)
- [ ] doesn't pop up automatically for users who have visited before and
closed it
- [ ] doesn't pop up automatically for staked users
- [ ] does come up with the correct message when you click it (standard
"hope you're enjoying...")
- [ ] does come up properly for a user connecting for the first time and
running through onboarding

7. Population
- [ ] shows on each realm (how we test that it's accurate, not sure but it
should show)
- [ ] shows on the bottom bar

8. Quests/Questline
- [ ] shows on each realm as expected

9. Disconnect from dapp
- [ ] click disconnect on address drop down and it disconnects and shows the
portal screen

10. Connect Wallet
- [ ] with Taho installed and default wallet
- [ ] with Taho installed and not default
- [ ] with Taho not installed and no other
- [ ] with Taho not installed and MM installed

0 comments on commit f45d2f3

Please sign in to comment.