Skip to content

Commit

Permalink
Switch to pull_request_target trigger in workflow adding test list (#…
Browse files Browse the repository at this point in the history
…616)

Despite having configured the workflow to trigger when a PR with base
branch `release` and head branch `stage-live` is opened, we didn't see
the workflow to trigger in those circumstances. We've tested similar
config in other repository and it was working there. The difference was
that in the other repository the PR opened wasn't showing warning about
the branch being out-of-date (and in case of the release PRs in `dapp`
we see that warning). So it looks that this may affect workflow
triggering.
In this PR we want to verify if changing the triggering event to
[`pull_request_target`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target)
will help. This event runs in the context of the base of the pull
request, not in the context of the merge commit.
  • Loading branch information
jagodarybacka authored Nov 2, 2023
2 parents f43d98b + 6a24f69 commit 27ec768
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/test-list.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
name: Add test list to release PRs

on:
pull_request:
pull_request_target:
types:
- opened
branches:
Expand Down

0 comments on commit 27ec768

Please sign in to comment.