Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CreateAssemblyGenerator.exe by CreateAssemblyGenerator.ps1 #68

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TheConstructor
Copy link

I couldn't find the source of CreateAssemblyGenerator.exe and would like to render everything outside assembly compilation unix-compatible. Replacing the executable by a similar PowerShell-script should serve both purposes.

@lizbaron
Copy link
Contributor

Hey @TheConstructor,

We think this is a great idea, but did you try to run the build? When we pull the new code, it breaks the build in Windows. And when we fix the basics in Windows, it looks like it has missing parameters. Can you please look again?

--Liz

@TheConstructor
Copy link
Author

Hey @lizbaron,

I will try to make this more reliable. Just out of curiosity: which PowerShell may I require? I understand https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell that pwsh might be specific to PowerShell Core. I should be able to use powershell instead of pwsh on Windows.

Thank you for looking into this!

@TheConstructor
Copy link
Author

Hey @lizbaron,

could you try the version with powershell on Windows? It would also help me, if you could include the exact error. I currently mainly work on a Mac OS X machine and may not be able to reproduce all errors.

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants