This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
Enhance the forked tomcat shutdown mojo to ensure it waits for tomcat… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to shutdown gracefully. - The start and stop mojos now use a temporary file to indicate if an instance is running. - Add a new configuration property tomcatShutdownTimeout to indicate how many seconds the stop mojo should wait for tomcat to shutdown before timing out.
|
I find the forked mode useful for running jacoco code coverage reports. This change should ensure that the forked stop mojo waits for tomcat to finish otherwise the jacoco reports stage would run before the coverage results are written to disk. |
|
Are you still interested in this PR merged? Sorry for the delay. But I do not use Tomcat anymore for a while now and did not see your PR. Regards |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to shutdown gracefully. - The start and stop mojos now use a temporary file to indicate if an instance is running. - Add a new configuration property tomcatShutdownTimeout to indicate how many seconds the stop mojo should wait for tomcat to shutdown before timing out.