Update vtt.c cue_settings uninitialized variable #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error C4703 potentially uninitialized local pointer variable 'cue_settings' used ... libcaption\src\vtt.c 278 Though all code paths seem to initialize it. `parse_timestamps` always fill it in. And when that is called, `block_type` is set `VTT_CUE` which is the only path that uses it afterward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error C4703 potentially uninitialized local pointer variable 'cue_settings' used ... libcaption\src\vtt.c 278
Microsoft UWP compiler complains about it even though all code paths seem to initialize it.
parse_timestampsalways fill it: https://github.com/szatmary/libcaption/pull/52/files#diff-61993fbd8c570847e446e6264b8fc485R236And when that is called,
block_typeis setVTT_CUEwhich is the only path that uses it afterward:https://github.com/szatmary/libcaption/pull/52/files#diff-61993fbd8c570847e446e6264b8fc485R282