Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Moved tests for malaria-web app from automated-testing #365

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Fenn-CS
Copy link

@Fenn-CS Fenn-CS commented Jul 6, 2018

Signed-off-by: Fenn-25 [email protected]

Description

Moved unit tests from automated-testing/MACCTests2017/tests/unit/test_malaria_web.py to tests.py of malaria-web module.

Fixes #364

Type of Change:

  • Code
  • Quality Assurance

How Has This Been Tested?

Local run.

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

@Fenn-CS Fenn-CS changed the title Moved malaria-web app from automated-testing Moved tests for malaria-web app from automated-testing Jul 8, 2018
@Fenn-CS Fenn-CS changed the title Moved tests for malaria-web app from automated-testing Moved tests for malaria-web app from automated-testing [In-Progress] Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@systers systers deleted a comment Jul 8, 2018
@Fenn-CS Fenn-CS changed the title Moved tests for malaria-web app from automated-testing [In-Progress] Moved tests for malaria-web app from automated-testing Jul 10, 2018
self.assertFalse(delete_post_by_id(999))
self.assertFalse(delete_post_by_id(999999))

def test_get_post_by_id(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fenn-CS I have a doubt here, won't the test_get_post_by_id fail? Since test_delete_post_by_id would have deleted the posts, which we are trying to fetch in the second test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I get it now :)

@Fenn-CS
Copy link
Author

Fenn-CS commented Jul 13, 2018 via email

@nida nida requested review from nida and MehaKaushik July 13, 2018 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants