T7 Add inactive/active button to Report Filter #17
Conversation
* show active and inactive reports on main map * TODO: **change coloring? -> depending on T6! **fix show inactive reports on map!
|
I'm a little confused about this one. What do you mean by active/inactive reports? Approved/unapproved? If this is the case, its good to note that only approved reports show up on the main map. Also, looks like the filter is duplicated. Ideal situation would be, add the active/inactive options right after the video filter. |
|
@aoduor Just as a heads-up, they actually don't want media filters listed at all, so I don't think that adding additional filters after the video filter is the best option. The active/inactive reports are another feature they want added where current projects are considered "active" and show up in a bright color on the map and old, already-ended projects are considered "inactive" and have a faded marker on the map. The color opacity is the only needed part of the feature listed in the requirements document though, so maybe having the active/inactive filter isn't necessary? |
|
thanks @jproft! okay, i'll get rid of the buttons then & just show inactive reports in a faded color. |
* FIRST commit! * change opacity according to category_id
|
I found this approach in a blog post, but I think you're right. This should be a separate function. I've only started with 4 categories, because that's the number of categories I had on the test server, but I'm aware that those should be more. |
|
Set the function such that it checks on categories dynamically as opposed to arbitrarily. The number of categories you have shouldn't affect how this works ;). |
* reset json controller * update sql to retrieve projects that ended * TODO: ** add function to return variable $color with changed opacity
|
okay, i'm on it! in the past commit i reverted the json-controller and i've added a sql statement to the incident-model that retrieves all project ended. i will now add a function that changes the opacity of the variable $color if the incident in question is in the project ended array. |
* test
|
(1) Should we have a button which points out inactive/active reports or (2) should we just show the active/inactive reports in a faded color. If we chose to do the latter one, the only problem I see is that you might not be able to tell if it is a multi-colored dot or not (see T6) |
|
Feedback from Amy : Project Status (Ended / Ongoing) should be indicated by a Filters - not faded colour (commits have been reverted and started from scratch) |
* add button to filter ongoing / ended projects * TODO: fix bug: map doesn’t update -> sql error?
* add column incident status to table incident * update db version
* fix parameters in helpers/reports * adapt sql-statement in sql * adapt reports/edit file
*add language files * fix layout issues and reports/edit
|
Documentation: http://jengeeks.wordpress.com/gsoc-2014/documentation/#InActiveButton only TODO: can't seem to be able to upload the given ui_main.php file |
|
Jen, what do you mean upload? To server? |
|
Sorry, i meant I couldn't commit my changes in the ui_main file |
*_change coloring? -> depending on T6!
*_fix show inactive reports on map!?