Fix Animation extensions being loaded in place of Sampler extensions #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of sample's extensions.
|
Good find! Do you have minimal reproducible gltf file? I'd like to add it to regression tests. |
|
I do but, unfortunately, I’m not allowed to share it.
… Le 8 août 2024 à 13:29, Syoyo Fujita ***@***.***> a écrit :
Good find!
Do you have minimal reproducible gltf file? I'd like to add it to regression tests.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
|
ok, the fix seems obvious so it'd be ready to merge. I wanted a test case for sure. |
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it all.
Currently, Animation Sampler extensions are not loaded and Animation extensions are loaded to their member instead.