Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1384 - player button press when playing #1772

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

w3cj
Copy link
Member

@w3cj w3cj commented Aug 8, 2024

  • This is a partial fix for [a11y]: Episode page - Skip links to jump to player #1384 - I did not add anything to jump to the player, just improved the button functionality
  • This fixes the player button on the show page
    • If the episode is already playing, pressing the play button will pause the episode
    • If the episode is paused, the button will say "resume"
    • If the site is freshly loaded to a show page that the user was last listening to, the button will say "resume"

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
syntax-website ✅ Ready (Inspect) Visit Preview Aug 8, 2024 7:57pm

@w3cj w3cj requested a review from stolinski August 8, 2024 19:57
@stolinski stolinski merged commit 43cff85 into main Aug 9, 2024
2 of 3 checks passed
@stolinski stolinski deleted the player-state-updates branch August 9, 2024 15:41
Copy link

sentry-io bot commented Aug 14, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted ... /(site)/show/[show_number]/[slug] View Issue
  • ‼️ NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted ... /(site)/show/[show_number]/[slug] View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants