Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to react-native-vision-camera #1990

Closed
wants to merge 1 commit into from
Closed

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Jun 13, 2024

Description

Removes react-native-camera-kit and replaces with react-native-vision-camera

Currently seeing a crash on android emulator when giving camera permission.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Insert relevant screenshot / recording

QA Notes

Make sure camera/scanner works as expected

Copy link

socket-security bot commented Jun 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 1.15 MB mrousavy

🚮 Removed packages: npm/[email protected]

View full report↗︎

@limpbrains
Copy link
Collaborator

Maybe try to upgrade react-native-camera-kit to 14.0.0-beta15 ?

@pwltr
Copy link
Collaborator Author

pwltr commented Jun 14, 2024

Currently seeing a crash on android emulator when giving camera permission.

This crash happens only on this PR (in the emulator). From what I've seen this camera performs better so switching would be a good idea. Maybe it will be fixed by upgrading to react-native 0.74.

@pwltr pwltr closed this Nov 5, 2024
@pwltr pwltr deleted the chore/vision-camera branch November 5, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants