remove auto destruct, and local code coverage build, update signal tests

symplely · Mar 29, 2020 · bd628c1 · bd628c1
1 parent 8fc6030
commit bd628c1
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 12 deletions.
diff --git a/Spawn/Launcher.php b/Spawn/Launcher.php
@@ -87,11 +87,6 @@ private function __construct(
         self::$launcher[$id] = $this;
     }
 
-    public function __destruct()
-    {
-        $this->close();
-    }
-
     public static function create(Process $process, int $id, int $timeout = 0, bool $isYield = false): LauncherInterface
     {
         return new self($process, $id, $timeout, null, null, null, null, null, $isYield);

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -26,11 +26,4 @@
             </exclude>
         </whitelist>
     </filter>
-
-	<logging>
-        <log type="junit" target="build/report.junit.xml"/>
-        <log type="coverage-html" target="build/coverage"/>
-        <log type="coverage-text" target="build/coverage.txt"/>
-        <log type="coverage-clover" target="build/logs/clover.xml"/>
-    </logging>
 </phpunit>
diff --git a/tests/SpawnTest.php b/tests/SpawnTest.php
@@ -246,6 +246,29 @@ public function testSignal()
         $this->assertEquals(\SIGKILL, $process->getSignaled());
     }
 
+    public function testSignalYield()
+    {
+        $counter = 0;
+
+        $process = Spawn::create(function () {
+            \sleep(10);
+        }, 0, null, true)->signal(\SIGKILL, function () use (&$counter) {
+            $counter += 1;
+        });
+
+        $process->stop();
+        $this->assertTrue($process->isRunning());
+        $yield = $process->yielding();
+        $this->assertTrue($yield instanceof \Generator);
+        $this->assertNull($yield->current());
+        $this->assertFalse($process->isRunning());
+        $this->assertFalse($process->isSuccessful());
+        $this->assertTrue($process->isTerminated());
+        $this->assertTrue($process->isSignaled());
+        //$this->assertEquals(1, $counter);
+        $this->assertEquals(\SIGKILL, $process->getSignaled());
+    }
+
     public function testIsSuccessfulCMD()
     {
         $process = Spawn::create('echo foo');