revert, stop() status should update after actual future execution

symplely · May 24, 2021 · 66ffef3 · 66ffef3
1 parent f953305
commit 66ffef3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/Spawn/Future.php b/Spawn/Future.php
@@ -487,7 +487,6 @@ public function stop(int $signal = \SIGKILL): FutureInterface
       $this->process->stop(0, $signal);
     }
 
-    $this->status = false;
     return $this;
   }
 

diff --git a/tests/SpawnTest.php b/tests/SpawnTest.php
@@ -252,7 +252,7 @@ public function testSignal()
     });
 
     $future->stop();
-    $this->assertFalse($future->isRunning());
+    $this->assertTrue($future->isRunning());
     $future->run();
     $this->assertFalse($future->isRunning());
     $this->assertFalse($future->isSuccessful());
@@ -273,7 +273,7 @@ public function testSignalYield()
     });
 
     $future->stop();
-    $this->assertFalse($future->isRunning());
+    $this->assertTrue($future->isRunning());
     $yield = $future->yielding();
     $this->assertTrue($yield instanceof \Generator);
     $this->assertNull($yield->current());
-Original file line number
+Diff line change
@@ Expand Up @@
           $this->process->stop(0, $signal);
         }
-        $this->status = false;
         return $this;
       }
@@ Expand Down @@