Fixes for upload driver #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `$value` was not always trimmed it caused a server 500 error on import. The error log was showing a line break e.g. ``` Fatal Error: ErrorException 0 - filesize(): stat failed for /path-redacted/workspace/images/ filename.jpg on line 39 of /path-redacted/extensions/importcsv/drivers/ImportDriver_upload.php ``` Also, the resulting import set a path for `$fileData['file']` because `$filename` was used I believe, so Symphony was complaining the file did not exist even though it was there and the link worked. Undoing the import, changing `$fileData['file']` to take the trimmed `$value` made the import work afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
$valuewas not always trimmed it caused a server 500 error on import. The error log was showing a line break e.g.Also, the resulting import set a path for
$fileData['file']because$filenamewas used I believe, so Symphony was complaining the file did not exist even though it was there and the link worked. Undoing the import, changing$fileData['file']to take the trimmed$valuemade the import work afterwards.