Update README.md #25
Open
Update README.md #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uncaught Error: Call to undefined function dump()
|
Thanks for your pull request! We love contributions. However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony repository. It is used by Composer to allow developers to depend on specific Symfony components. If you want to contribute, you should instead open a pull request on the main repository: https://github.com/symfony/symfony Thank you for your contribution! PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply. |
symfony-splitter
pushed a commit
that referenced
this pull request
Jul 20, 2022
…afimArts)
This PR was squashed before being merged into the 6.2 branch.
Discussion
----------
[VarDumper] Add `FFI\CData` and `FFI\CType` types
| Q | A
| ------------- | ---
| Branch? | 6.2
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Added support of FFI:
```php
$ffi = \FFI::cdef(<<<'CPP'
typedef struct { int x; int y; } Point;
typedef struct Example {
uint8_t array[32];
long longVal;
__extension__ union {
__extension__ struct { short shortVal; };
struct { Point point; float e; };
};
bool boolValue;
int (*func)(struct __sub *h);
} Example;
CPP);
$struct = $ffi->new('Example');
$struct->func = (static fn (object $ptr) => 42);
dump($struct);
```
**Before**
```
FFI\CData {#2}
```
**After**
```
FFI\CData<struct Example> size 64 align 8 {#2
+array: FFI\CData<uint8_t[32]> size 32 align 1 {#18}
+int32_t longVal: 0
+int16_t shortVal: 0
+point: FFI\CData<struct <anonymous>> size 8 align 4 {#17
+int32_t x: 0
+int32_t y: 0
}
+float e: 0.0
+bool boolValue: false
+func: [cdecl] callable(struct __sub*): int32_t {#20
returnType: FFI\CType<int32_t> size 4 align 4 {#25}
}
}
```
P.S. I apologize for the multiple force pushes, errors in tests and codestyle have been fixed.
## Review And TODOs
- Pointers
- [x] Pointer to scalar tests.
- [x] Pointer to struct tests.
- [x] "Special" pointer to `char*` tests (with `\0` and without `\0`).
- Possible Errors
- [x] Do not dump union fields with pointer references (possible SIGSEGV).
Commits
-------
1c7dc52abb [VarDumper] Add `FFI\CData` and `FFI\CType` types
you have a typo there.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncaught Error: Call to undefined function dump()