Cast boolean env variables #632
Open
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase so that we can trigger the CI again also? |
nicolas-grekas
approved these changes
Oct 3, 2024
OskarStark
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #164
Environment variables are always casted to strings, so added PHP
filter_var()to cast$_SERVERvariables at if statements.I think for argument
PANTHER_DEVTOOLSits required to be able to set it tofalse, while for argumentsPANTHER_NO_HEADLESSandPANTHER_NO_SANDBOXarefalseby default andtrueif they just defined.Hence, another applicable solution is to convert
PANTHER_DEVTOOLStoPANTHER_NO_DEVTOOLS