Add recipe provider which loads recipes directly from the bundle. #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ersatzhero
force-pushed
the
feature/localrecipeprovider
branch
4 times, most recently
from
a2f1f4b
to
de737ac
Compare
ersatzhero
force-pushed
the
feature/localrecipeprovider
branch
from
de737ac
to
0a17d17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds a "LocalRecipeProvider", that also looks in installed bundles for installable recipes.
I couldn't unit test this, as phpunit throws errors, when I try to run it.
PHP Parse error: syntax error, unexpected '=' in /opt/project/vendor/symfony/string/Resources/functions.php on line 34Also I don't know the requirements for a pull request.
If there are any, that I have missed, please let me know.