[wallet/desktop] feat: unit test spinner #1906
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/unit-tests-united-2 #1906 +/- ##
===============================================================
+ Coverage 34.63% 34.71% +0.08%
===============================================================
Files 586 585 -1
Lines 14033 14031 -2
Branches 2358 2358
===============================================================
+ Hits 4860 4871 +11
+ Misses 9107 9094 -13
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Jaguar0625
reviewed
Aug 29, 2022
| }); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
can you add test for what is rendered when disableCloseButton is true and false?
There was a problem hiding this comment.
I was not able to test it, it just render out <div /> as output.
I will try again to play around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the issue?
SpinnerLoadingcomponent.What's the fix?
SpinnerLoadingcomponent.SpinnerDots